Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows setting maximum column width --columns-width #306

Closed
wants to merge 2 commits into from

Conversation

jm66
Copy link

@jm66 jm66 commented Oct 15, 2019

@homeassistant
Copy link

Hi @jm66,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #306 into dev will decrease coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #306      +/-   ##
==========================================
- Coverage   75.25%   75.01%   -0.25%     
==========================================
  Files          22       22              
  Lines        1560     1545      -15     
==========================================
- Hits         1174     1159      -15     
  Misses        386      386
Impacted Files Coverage Δ
homeassistant_cli/helper.py 74.74% <100%> (+0.78%) ⬆️
homeassistant_cli/const.py 100% <100%> (ø) ⬆️
homeassistant_cli/cli.py 76.66% <100%> (+0.53%) ⬆️
homeassistant_cli/plugins/raw.py 86.84% <0%> (-3.36%) ⬇️
homeassistant_cli/autocompletion.py 73.4% <0%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa918dd...bc98d8e. Read the comment docs.

jm66 added 2 commits October 16, 2019 10:52
- If specified --columns-width or HASS_COL_WIDTH env var
  truncates column values
- Uses default const.COLUMNS_WIDTH_STR
- Fixes home-assistant-ecosystem#253
@jm66 jm66 force-pushed the proposal-column-width branch from 087daab to bc98d8e Compare October 16, 2019 14:53
@jm66
Copy link
Author

jm66 commented Oct 16, 2019

this is a mess. starting from scratch. sorry.

@jm66 jm66 closed this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow setting maximum column width (feature req)
3 participants