Fix: modified parsing for ENVS in pr-deploy.sh

hngprojects · Aug 2, 2024 · 7bf5a58 · 7bf5a58
1 parent 1074188
commit 7bf5a58
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/entrypoint.sh b/entrypoint.sh
@@ -69,7 +69,7 @@ if [ "$PR_ACTION" == "opened" ]; then
 fi
 
 echo "ENVS1=$ENVS"
-ENV_ARGS=$(echo "$ENVS" | tr '\n' ' ' )
+ENV_ARGS=$(echo "$ENVS" | tr '\n' ',' )
 echo "ENV_ARGS=$ENV_ARGS"
 
 # Copy the pr-deploy.sh script to the remote server.

diff --git a/pr-deploy.sh b/pr-deploy.sh
@@ -10,7 +10,7 @@ REPO_ID=$5
 BRANCH=$6
 PR_ACTION=$7
 PR_NUMBER=$8
-ENV_ARGS="$9"
+ENVS="$9"
 COMMENT_ID=${10}
 PR_ID="pr_${REPO_ID}${PR_NUMBER}"
 # JSON file to store PIDs
@@ -110,11 +110,11 @@ sudo docker build -t $PR_ID -f $DOCKERFILE .
 echo "Running docker container..."
 # sudo docker run -d -p $FREE_PORT:$EXPOSED_PORT --name $PR_ID $PR_ID
 
-ENVS=$(echo "$ENVS" | tr ' ' '\n' | sed 's/^/-e /' | tr '\n' ' ')
+ENV_ARGS=$(echo "$ENVS" | tr ',' '\n' | sed 's/^/-e /' | tr '\n' ' ')
 # ENV_ARGS=$(echo "$ENVS" | sed 's/^/-e /' | tr '\n' ' ')
 # echo "ENV_ARGS: $ENVS"
 # ENV_ARGS=$(echo "$ENVS" | sed 's/^/-e /' | sed ':a;N;$!ba;s/\n/ -e /g')
-sudo docker run -d "$ENVS" -p $FREE_PORT:$EXPOSED_PORT --name $PR_ID $PR_ID
+sudo docker run -d $ENV_ARGS -p $FREE_PORT:$EXPOSED_PORT --name $PR_ID $PR_ID
 
 echo "Start SSH session..."
 nohup ssh -tt -o StrictHostKeyChecking=no -R 80:localhost:$FREE_PORT serveo.net > serveo_output.log 2>&1 &