Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/HNG-17-success-page-for-magic-link #266

Merged

Conversation

oyin-systems
Copy link
Collaborator

@oyin-systems oyin-systems commented Jul 21, 2024

Description

Closes #17

Changes proposed

What were you told to do?

Title: Authentication Page -> Success page for magic link #17
Acceptance Criteria:
Responsive across all screen sizes (desktop, tablet and mobile)
Write tests for your code.
Use components where necessary (header, footer, buttons, modal and so on)

What did you do?

I created a new page (Magicsuccess.tsx) and made it available as a route on the home page. I also had to create header and footer components since it was needed to complete the page and no one has worked on it. Then I performed tests according to the instructions.

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

Desktop
desktop
Tablet
tablet
Mobile
mobile

Link to Figma File

Design

@psalm987
Copy link
Collaborator

Send screenshots of responsiveness.

@oyin-systems
Copy link
Collaborator Author

oyin-systems commented Jul 21, 2024

Send screenshots of responsiveness.

Done. @psalm987

@psalm987 psalm987 merged commit 40fd46a into hngprojects:dev Jul 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Authentication Page -> Success page for magic link
2 participants