Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: single product admin #576

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/controllers/AdminController.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { Request, Response } from "express";
import { check, param, validationResult } from "express-validator";
import { UserRole } from "../enums/userRoles";
import { HttpError } from "../middleware";
import {
AdminLogService,
AdminOrganisationService,
AdminUserService,
AdminLogService,
} from "../services";
import { HttpError } from "../middleware";
import { check, param, validationResult } from "express-validator";
import { UserRole } from "../enums/userRoles";

/**
* @swagger
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/ProductController.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { NextFunction, Request, Response } from "express";
import { ProductService } from "../services/product.services";
import { BadRequest } from "../middleware";
import { ProductService } from "../services/product.services";

class ProductController {
private productService: ProductService;
Expand Down
9 changes: 7 additions & 2 deletions src/middleware/request-validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,14 @@ const requestBodyValidator = (schema: ZodSchema<any>) => {
next();
} catch (err) {
if (err instanceof ZodError) {
return res.status(400).json({
const errorMessages = err.errors.map((error: any) => ({
path: `${error.path.join(",")}`,
message: `${error.message}`,
}));

return res.status(422).json({
message: "Invalid request body",
// errors: err.errors,
errors: errorMessages,
});
}
next(err);
Expand Down
17 changes: 12 additions & 5 deletions src/models/product.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import {
Entity,
PrimaryGeneratedColumn,
Column,
CreateDateColumn,
DeleteDateColumn,
Entity,
ManyToOne,
PrimaryGeneratedColumn,
UpdateDateColumn,
CreateDateColumn,
} from "typeorm";
import { Organization } from "./organization";
import ExtendedBaseEntity from "./extended-base-entity";
import { ProductSize, StockStatus } from "../enums/product";
import ExtendedBaseEntity from "./extended-base-entity";
import { Organization } from "./organization";
import { User } from "./user";
@Entity()
export class Product extends ExtendedBaseEntity {
Expand Down Expand Up @@ -58,4 +59,10 @@ export class Product extends ExtendedBaseEntity {

@ManyToOne(() => User, (user) => user.products)
user: User;

@Column({ type: "float", nullable: false, default: 0 })
cost_price: number;

@DeleteDateColumn()
deletedAt?: Date;
}
3 changes: 1 addition & 2 deletions src/routes/admin.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { Router } from "express";
import admin from "../controllers/AdminController";
import { authMiddleware, checkPermissions } from "../middleware";
import { UserRole } from "../enums/userRoles";
import { Organization } from "../models";
import { authMiddleware, checkPermissions } from "../middleware";
import { Limiter } from "../utils";

const adminRouter = Router();
Expand Down
6 changes: 3 additions & 3 deletions src/routes/organisation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ orgRouter.delete(
);

orgRouter.post(
"/organizations",
"/organisations",
authMiddleware,
organizationValidation,
orgController.createOrganisation.bind(orgController),
Expand Down Expand Up @@ -87,13 +87,13 @@ orgRouter.put(
);

orgRouter.get(
"/organizations/:org_id/roles/:role_id",
"/organisations/:org_id/roles/:role_id",
authMiddleware,
orgController.getSingleRole.bind(orgController),
);

orgRouter.get(
"/organizations/:org_id/roles",
"/organisations/:org_id/roles",
authMiddleware,
orgController.getAllOrganizationRoles.bind(orgController),
);
Expand Down
11 changes: 5 additions & 6 deletions src/routes/product.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
import { Router } from "express";
import { ProductController } from "../controllers/ProductController";
import { authMiddleware, validOrgAdmin } from "../middleware";
import { validateProductDetails } from "../middleware/product";
import { validateUserToOrg } from "../middleware/organizationValidation";
import { adminOnly } from "../middleware";
import { requestBodyValidator } from "../middleware/request-validation";
import { productSchema } from "../schema/product.schema";

const productRouter = Router();
const productController = new ProductController();

// route
productRouter.post(
"/organizations/:org_id/products",
validateProductDetails,
requestBodyValidator(productSchema),
authMiddleware,
validOrgAdmin,
productController.createProduct,
Expand All @@ -25,14 +24,14 @@ productRouter.get(
);

productRouter.delete(
"/organizations/:org_id/products/:product_id",
"/organisations/:org_id/products/:product_id",
authMiddleware,
validOrgAdmin,
productController.deleteProduct,
);

productRouter.get(
"/organizations/:org_id/products/:product_id",
"/organisations/:org_id/products/:product_id",
authMiddleware,
validOrgAdmin,
productController.getSingleProduct,
Expand Down
11 changes: 7 additions & 4 deletions src/schema/product.schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@ import { z } from "zod";

export const productSchema = z.object({
name: z.string().min(1, "Name is required"),
description: z.string().optional(),
category: z.string().optional(),
price: z.number().min(1, "Price is required"),
image: z.string().optional(),
description: z.string().min(1, "Description is required"),
category: z.string().min(1, "Category is required"),
price: z.number().min(0.1, "Price is required and must be greater than 0"),
image: z.string(),
quantity: z.number().min(1, "Quantity is required"),
cost_price: z
.number()
.min(0.1, "Cost price is required and must be greater than 0"),
});

export type ProductSchema = z.infer<typeof productSchema>;
Expand Down
4 changes: 2 additions & 2 deletions src/services/admin.services.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// / src/services/AdminOrganisationService.ts
import { NextFunction, Request, Response } from "express";
import { Request } from "express";
// import { getRepository, Repository } from 'typeorm';
import { User, Organization, Log } from "../models";
import AppDataSource from "../data-source";
import { HttpError } from "../middleware";
import { Log, Organization, User } from "../models";
import { hashPassword } from "../utils/index";

export class AdminOrganisationService {
Expand Down
1 change: 0 additions & 1 deletion src/services/product.services.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ export class ProductService {
if (!organization) {
throw new ServerError("Invalid organisation credentials");
}

const newProduct = this.productRepository.create(new_Product);
newProduct.org = organization;
newProduct.stock_status = await this.calculateProductStatus(
Expand Down
Loading