-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTSPB-4458 Add a11y context for summary page links #2380
Draft
tom-saunders-cts
wants to merge
4
commits into
master
Choose a base branch
from
DTSPB-4458-a11y-change-link-ctx
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plan Result (aat)
Change Result (Click me) # module.probate-frontend-redis-cache.azurerm_redis_cache.redis will be updated in-place
~ resource "azurerm_redis_cache" "redis" {
id = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/probate-frontend-redis-cache-cache-aat/providers/Microsoft.Cache/redis/probate-frontend-redis-cache-aat"
name = "probate-frontend-redis-cache-aat"
tags = {
"application" = "probate"
"autoShutdown" = "true"
"builtFrom" = "https://github.com/HMCTS/probate-frontend.git"
"businessArea" = "CFT"
"contactSlackChannel" = "#probate"
"environment" = "staging"
"managedBy" = "Probate"
}
# (24 unchanged attributes hidden)
~ redis_configuration {
~ maxfragmentationmemory_reserved = 125 -> 642
~ maxmemory_delta = 125 -> 642
~ maxmemory_reserved = 125 -> 642
# (14 unchanged attributes hidden)
}
}
Plan: 0 to add, 1 to change, 0 to destroy. |
Plan Result (prod)
|
tom-saunders-cts
force-pushed
the
DTSPB-4458-a11y-change-link-ctx
branch
3 times, most recently
from
January 24, 2025 12:10
94c7783
to
a26cf76
Compare
This method generates a random 8 digit number, left padded with zeros. This can then be used to uniquely id items in template generated handling.
This means that the elements can be reliably referenced. This approach means that a screen reader will read 'Change xyz' or 'Answer xyz' rather than just 'Change' or 'Answer'. This may not be ideal in welsh, but I don't know what our normal interaction between i18n and a11y expectations are.
tom-saunders-cts
force-pushed
the
DTSPB-4458-a11y-change-link-ctx
branch
from
January 24, 2025 12:36
a26cf76
to
c79de0b
Compare
…ded. Currently unimplemented for anything.
tom-saunders-cts
force-pushed
the
DTSPB-4458-a11y-change-link-ctx
branch
3 times, most recently
from
January 24, 2025 15:53
b2bc266
to
7d2800a
Compare
tom-saunders-cts
force-pushed
the
DTSPB-4458-a11y-change-link-ctx
branch
from
January 24, 2025 16:10
7d2800a
to
348af89
Compare
tom-saunders-cts
force-pushed
the
DTSPB-4458-a11y-change-link-ctx
branch
from
January 24, 2025 16:45
348af89
to
5c78bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
See DTSPB-4458
Change description
Adds a random string generation method into the nunjucks context, then uses that to provide
id
attributes for templated summary page elements. Theseid
values are then used witharia-labelledby
to add the context for each of the 'Change' or 'Answer' links.Does this PR introduce a breaking change? (check one with "x")