Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTSPB-4458 Add a11y context for summary page links #2380

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tom-saunders-cts
Copy link
Contributor

JIRA link (if applicable)

See DTSPB-4458

Change description

Adds a random string generation method into the nunjucks context, then uses that to provide id attributes for templated summary page elements. These id values are then used with aria-labelledby to add the context for each of the 'Change' or 'Answer' links.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@hmcts-jenkins-j-to-z
Copy link
Contributor

Plan Result (aat)

Plan: 0 to add, 1 to change, 0 to destroy.
  • Update
    • module.probate-frontend-redis-cache.azurerm_redis_cache.redis
Change Result (Click me)
  # module.probate-frontend-redis-cache.azurerm_redis_cache.redis will be updated in-place
  ~ resource "azurerm_redis_cache" "redis" {
        id                                 = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/probate-frontend-redis-cache-cache-aat/providers/Microsoft.Cache/redis/probate-frontend-redis-cache-aat"
        name                               = "probate-frontend-redis-cache-aat"
        tags                               = {
            "application"         = "probate"
            "autoShutdown"        = "true"
            "builtFrom"           = "https://github.com/HMCTS/probate-frontend.git"
            "businessArea"        = "CFT"
            "contactSlackChannel" = "#probate"
            "environment"         = "staging"
            "managedBy"           = "Probate"
        }
        # (24 unchanged attributes hidden)

      ~ redis_configuration {
          ~ maxfragmentationmemory_reserved         = 125 -> 642
          ~ maxmemory_delta                         = 125 -> 642
          ~ maxmemory_reserved                      = 125 -> 642
            # (14 unchanged attributes hidden)
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@hmcts-jenkins-j-to-z
Copy link
Contributor

Plan Result (prod)

No changes. Your infrastructure matches the configuration.

This method generates a random 8 digit number, left padded with zeros.
This can then be used to uniquely id items in template generated handling.
This means that the elements can be reliably referenced. This approach means that
a screen reader will read 'Change xyz' or 'Answer xyz' rather than just 'Change'
or 'Answer'. This may not be ideal in welsh, but I don't know what our normal
interaction between i18n and a11y expectations are.
@tom-saunders-cts tom-saunders-cts force-pushed the DTSPB-4458-a11y-change-link-ctx branch 3 times, most recently from b2bc266 to 7d2800a Compare January 24, 2025 15:53
@tom-saunders-cts tom-saunders-cts force-pushed the DTSPB-4458-a11y-change-link-ctx branch from 7d2800a to 348af89 Compare January 24, 2025 16:10
@MarcusHMCTS MarcusHMCTS deleted the DTSPB-4458-a11y-change-link-ctx branch January 24, 2025 16:30
@MarcusHMCTS MarcusHMCTS restored the DTSPB-4458-a11y-change-link-ctx branch January 24, 2025 16:37
@MarcusHMCTS MarcusHMCTS reopened this Jan 24, 2025
@tom-saunders-cts tom-saunders-cts force-pushed the DTSPB-4458-a11y-change-link-ctx branch from 348af89 to 5c78bd6 Compare January 24, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants