DUMMY preview rebase #2377
Draft
DUMMY preview rebase #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be the location the referenced parameter is used (along with locale which is not mentioned) directly. The behaviour here should now be that: - we iterate left to right through 'lng' parameters - if we find one which is in our list of languages we use it - if not we iterate left to right through 'locale' parameters - if we find one which is in our list of languages we use it - otherwise we use english
This was previously defaulted through helmet, but we have been flagged as the value not being sufficiently long.
Also use long name for hsts (strictTransportSecurity) since this matches the name of the header (similar to the other helmet uses).
I think this should make testing slightly cleaner?
I have not been able to figure a way to confirm that the resulting output is passed to the express app itself as i can't seem to intercept the original express() call in app.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dummy