10 target framework net70 is unsupported upgrade #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 23, 2025 15:34
* changed framework to v8 * bumped dependencies as needed * out-of-source build as target * removed build files from source * added correct copy command for specification file * removed VS studio file. It can be generated. * removed launch config files, they are IDE dependent and should be replaced by a test.
ir4y
reviewed
Jan 24, 2025
| <PackageReference Include="Hl7.Fhir.R4" Version="5.6.1" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="Hl7.Fhir.R4B" Version="5.11.1" /> |
There was a problem hiding this comment.
@heathfrankel could you please advice here?
May update to r4b cause some possible issues?
As far as I know au-core is based on r4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a bit of merge train. It does what it says on the box (update to net70), but it actually includes some of the others. Again, since this changes dependencies to accommodate the framework test, it needs (sigh) manual testing.