Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imageUrl and memory limit for validator-api #14

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

projkov
Copy link
Collaborator

@projkov projkov commented Jan 27, 2025

Usage of the new validator-api image with actual official wrapper version + precached of the AU Core IG.

Changes:

  1. Change imageUrl to new (https://github.com/beda-software/au-core-validator-wrapper)
  2. Increase the size of the memory limit from 1 GB to 10 GB.

@projkov projkov requested a review from KyleOps January 27, 2025 14:36
Copy link

Terraform Plan Output

Click to expand
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # helm_release.inferno will be updated in-place
  ~ resource "helm_release" "inferno" {
        id                         = "dev-inferno"
      ~ metadata                   = [
          - {
              - app_version    = "1.16.0"
              - chart          = "inferno-helmd"
              - first_deployed = 1736748538
              - last_deployed  = 1737986752
              - name           = "dev-inferno"
              - namespace      = "dev-inferno"
              - revision       = 10
              - values         = jsonencode(
                    {
                      - controller = {
                          - enabled              = false
                          - ingressClass         = "nginx"
                          - ingressClassResource = {
                              - default = false
                              - enabled = true
                              - name    = "nginx"
                            }
                          - service              = {
                              - annotations = {
                                  - "service.beta.kubernetes.io/aws-load-balancer-type" = "nlb"
                                }
                            }
                        }
                      - inferno    = {
                          - externalValidatorUrl = null
                          - imageUrl             = "ghcr.io/hl7au/au-fhir-inferno:b087ebecc0512846da5cc5465d18f4cfc423632c"
                          - terminologyServer    = "https://tx.dev.hl7.org.au/fhir"
                          - usesWrapper          = true
                          - validatorImageUri    = "pavelrozhkov/wrapper:6.3.11"
                        }
                      - ingress    = {
                          - hostnames = [
                              - "dev.inferno.sparked-fhir.com",
                              - "inferno.dev.hl7.org.au",
                            ]
                        }
                      - nginx      = {
                          - example          = 1234
                          - platformImageUri = "ghcr.io/hl7au/au-fhir-inferno:b087ebecc0512846da5cc5465d18f4cfc423632c-nginx"
                        }
                      - postgresql = {
                          - containerPorts = {
                              - postgresql = 5432
                            }
                          - enabled        = false
                          - externaldbhost = "(sensitive value)"
                          - global         = {
                              - postgresql = {
                                  - auth = {
                                      - database = "inferno"
                                      - password = "(sensitive value)"
                                      - username = "(sensitive value)"
                                    }
                                }
                            }
                        }
                    }
                )
              - version        = "0.2.0"
                # (1 unchanged attribute hidden)
            },
        ] -> (known after apply)
        name                       = "dev-inferno"
      ~ values                     = [
          ~ <<-EOT
                ingress:
                  hostnames:
                    - example.inferno.sparked-fhir.com
                    - example.inferno.hl7.org.au
                
                inferno:
                  imageUrl: "ghcr.io/hl7au/au-fhir-inferno:68270162fcc1997a9ffac63c78530921bf0f32cf"
                  terminologyServer: "https://tx.dev.hl7.org.au/fhir"
                  externalValidatorUrl: null  # This can be overridden during chart deployment
              -   validatorImageUri: "pavelrozhkov/wrapper:6.3.11"
              +   validatorImageUri: "ghcr.io/beda-software/validator-wrapper:latest"
                
                controller:
                  enabled: false # Set to true to enable the ingress controller if you have not already installed it, multiple ingress controllers can be installed via https://kubernetes.github.io/ingress-nginx/user-guide/multiple-ingress/
                  ingressClass: "nginx"
                  ingressClassResource:
                    name: nginx
                    enabled: true
                    default: false
                  service:
                    annotations:
                      service.beta.kubernetes.io/aws-load-balancer-type: "nlb"
                
                postgresql:
                  enabled: false # enable if not using rds from aws-impl
                  externaldbhost: null # This can be overridden during chart deployment
                  containerPorts:
                    postgresql: 5432
                  global:
                    postgresql:
                      auth:
                        username: "postgres"
                        password: "password"
                        database: "inferno"
            EOT,
        ]
        # (25 unchanged attributes hidden)

      - set {
          - name  = "inferno.validatorImageUri" -> null
          - value = "pavelrozhkov/wrapper:6.3.11" -> null
            # (1 unchanged attribute hidden)
        }
      + set {
          + name  = "inferno.validatorImageUri"
          + value = "ghcr.io/beda-software/validator-wrapper:latest"
            # (1 unchanged attribute hidden)
        }

        # (9 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Copy link
Collaborator

@KyleOps KyleOps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 gb seems high compared to the previous wrapper but optimisation can come later, LGTM

@projkov projkov merged commit 69eda16 into master Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants