Don't tokenize --pre=all
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
a warning that the task was not dependent on "all".
wxtim
force-pushed
the
hilary.cylc-set-task.all-bug
branch
from
a8586f5 to
f639513
Compare
wxtim
commented
Feb 8, 2024
| for prereq in (prereqs or []) | ||
| ] | ||
| _prereqs: 'Union[List[Tokens], Literal["all"]]' | ||
| if prereqs == ['all']: |
There was a problem hiding this comment.
No point in carrying around the extra data structure of the list.
wxtim
commented
Feb 8, 2024
| @@ -1393,8 +1393,8 @@ async def test_set_outputs_live( | |||
| 'runtime': { | |||
| 'foo': { | |||
| 'outputs': { | |||
| 'x': 'x', | |||
| 'y': 'y' | |||
| 'x': 'xylophone', | |||
There was a problem hiding this comment.
Unfortunately this change reveals a second bug caused by the message and the output having the same value.
I'm working on getting to the bottom of the why, but it looks to me like it's in the three satisfy_me methods.
prerequisite.satisfied seems to use a key of (cycle, name, message) (I checked on master too), but the tokens being passed to this method are looking for (cycle, name, output).
|
Thanks @wxtim - I'll merge this then look at the other bug you've flagged here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leading to a warning that the task was not dependent on "all".
Bug created at 1c656ef