Merge pull request #74 from hisabi-app/feat/update-budget-schema

feature: update budget schema
hisabi-app · Apr 22, 2024 · f6dc9e5 · f6dc9e5
2 parents 9a33e1c + 6c760a8
commit f6dc9e5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/app/Models/Budget.php b/app/Models/Budget.php
@@ -42,7 +42,7 @@ public function getEndAtDateAttribute()
         return $this->getCurrentWindowStartAndEndDates()[1]->format('Y-m-d');
     }
 
-    public function getTotalAccumulatedTransactionsAmountAttribute()
+    public function getTotalTransactionsAmountAttribute()
     {
         $categories = $this->categories()->with('transactions')->get();
         [$startAt, $endAt] = $this->getCurrentWindowStartAndEndDates();

diff --git a/graphql/schema.graphql b/graphql/schema.graphql
@@ -16,8 +16,9 @@ type Category {
 
 type Budget {
     id: ID!
+    name: String!
     amount: Float!
-    totalAccumulatedTransactionsAmount: Float!
+    totalTransactionsAmount: Float!
     startAtDate: String!
     endAtDate: String!
 }

diff --git a/tests/Unit/Models/Budgets/BudgetTest.php b/tests/Unit/Models/Budgets/BudgetTest.php
@@ -31,7 +31,7 @@ public function it_belongs_to_categories()
     }
 
     /** @test */
-    public function it_has_total_categories_transactions_amount()
+    public function it_has_total_transactions_amount()
     {
         $category = Category::factory()->create();
         $brand = Brand::factory()->create(['category_id' => $category->id]);
@@ -42,7 +42,7 @@ public function it_has_total_categories_transactions_amount()
         $category->transactions()->create(['amount' => 200, 'brand_id' => $brand->id]);
         $category->transactions()->create(['amount' => 200, 'brand_id' => $brand->id, 'created_at' => now()->addDays(2)]);
 
-        $this->assertEquals(300, $sut->totalAccumulatedTransactionsAmount);
+        $this->assertEquals(300, $sut->totalTransactionsAmount);
     }
 
     /** @test */