Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs: #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix some bugs: #1

wants to merge 3 commits into from

Conversation

yola-0316
Copy link

Fix for that issues:
If the filename like below:
custom-a-b.css
main-test.js
the replace will apply in props

the manifest.json will be:
{
"custom-a.css?v=b": "custom-a-b.css?v=xxxxx",
"main.js?v=test": "main-test.js?v=xxxxx"
}

So, I parse the string to Object, then travel it, only replace the
value in object.

x4storm added 2 commits July 21, 2017 01:52
Fix for that issues:
If the filename like below:
custom-a-b.css
main-test.js
the replace will apply in props

the  manifest.json will be:
{
  "custom-a.css?v=b": "custom-a-b.css?v=xxxxx",
  "main.js?v=test": "main-test.js?v=xxxxx"
}

So, I parse the string to Object, then travel it, only replace the
value in object.
Fix for this issues:
filename:
jquery.1.7.0.js
test.min.js

for multi dots in finename
@yola-0316
Copy link
Author

Fix for this issues:
filename:
jquery.1.7.0.js
test.min.js

for multi dots in finename

Fix for this filename:
angular-datatables.light-columnfilter.a.js

beacause the gulp-rev always prepend hash in first dots.
so reg should consider after .-
@yola-0316
Copy link
Author

Fix for this issues:
filename:
jquery.1.7.0.js
test.min.js

for multi dots in finename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant