Update bom master to upstream master #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonjunweilyu, @lukehoffmann : I wonder if it would be worth to add this repo to lfric_atm-fab as sub-repo. Then we could do a merge like this immediately (I don't think it really needs code review, since it's a merge from upstream master, with trivial conflicts resolved). Then we can fix up lfric_atm, update the module, and would always have a matching fab version with lfric_fab-atm (and it would also make it easier to get something up and running for NG-ARCH). |
jasonjunweilyu
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the code review for ArtefactStore improvements,
ALL_SOURCEwas renamed toINITIAL_SOURCE, which affects many files (though only trivial renames), and could break other scripts (lfric_atm-fab??)