Skip to content

Commit

Permalink
Removed enforcement of keyword parameters, which is not supported in …
Browse files Browse the repository at this point in the history
…python 3.7.
  • Loading branch information
hiker committed Jul 25, 2024
1 parent d00c187 commit e9333fd
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions source/fab/tools/compiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,8 @@ def openmp_flag(self) -> str:
'''
return self._openmp_flag

# Note the / enforces to use keyword arguments for all remaining
# parameters. This makes sure parameters are not getting mixed up.
def compile_file(self, input_file: Path,
output_file: Path,
/,
openmp: bool,
add_flags: Union[None, List[str]] = None):
'''Compiles a file. It will add the flag for compilation-only
Expand Down
3 changes: 0 additions & 3 deletions source/fab/tools/linker.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,7 @@ def check_available(self) -> bool:

return super().check_available()

# The / enforces that all other parameters are provided as keyword
# parameters, which avoids mistakes.
def link(self, input_files: List[Path], output_file: Path,
/,
openmp: bool,
add_libs: Optional[List[str]] = None) -> str:
'''Executes the linker with the specified input files,
Expand Down

0 comments on commit e9333fd

Please sign in to comment.