-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIP dependencies refactor #768
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are passing and the server runs
Codecov Report
@@ Coverage Diff @@
## develop #768 +/- ##
========================================
Coverage 57.55% 57.55%
========================================
Files 140 140
Lines 9210 9210
========================================
Hits 5301 5301
Misses 3909 3909 |
michaelbukachi
previously approved these changes
Sep 2, 2021
michaelbukachi
previously approved these changes
Sep 2, 2021
…a-io/activity into 767-pip-tools-dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the Purpose?
Cleanup of dependencies and reorganising them using pip-tools
What was the approach?
Used pip-tools to manage dependencies.
Updated old pipenv usage from Github Actions and documentations.
Added documentation about how/why dependencies are managed with pip-tools
Are there any concerns to addressed further before or after merging this PR?
None
Mentions?
@michaelbukachi @Kimaiyo077
Issue(s) affected?
Closes #767