Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement metrics for block stream bucket uploader #17314

Closed

Merge branch 'main' into 16977-block-stream-bucket-uploader-metrics

84b5ec9
Select commit
Loading
Failed to load commit list.
Closed

feat: implement metrics for block stream bucket uploader #17314

Merge branch 'main' into 16977-block-stream-bucket-uploader-metrics
84b5ec9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 15, 2025 in 0s

67.97% (+0.02%) compared to 84fb83b

View this Pull Request on Codecov

67.97% (+0.02%) compared to 84fb83b

Details

Codecov Report

Attention: Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.97%. Comparing base (84fb83b) to head (84b5ec9).

Files with missing lines Patch % Lines
...e/app/blocks/BlockStreamBucketUploaderMetrics.java 98.50% 0 Missing and 1 partial ⚠️
.../com/hedera/node/app/info/InfoInjectionModule.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17314      +/-   ##
============================================
+ Coverage     67.95%   67.97%   +0.02%     
- Complexity    22344    22363      +19     
============================================
  Files          2606     2607       +1     
  Lines         96901    96969      +68     
  Branches      10098    10099       +1     
============================================
+ Hits          65845    65913      +68     
+ Misses        27295    27294       -1     
- Partials       3761     3762       +1     
Files with missing lines Coverage Δ
...e/app/blocks/BlockStreamBucketUploaderMetrics.java 98.50% <98.50%> (ø)
.../com/hedera/node/app/info/InfoInjectionModule.java 33.33% <0.00%> (-16.67%) ⬇️

... and 3 files with indirect coverage changes

Impacted file tree graph