HV-2073 Add new OneOfValidator for CharSequence validation #1540

aalamu · 2024-12-30T16:01:20Z

Description:

Contributed a new OneOfValidator for the Hibernate Validator project.

This validator checks if a given CharSequence matches one of the allowed values specified in the OneOf annotation.

Features:

Validates if a CharSequence is one of the allowed values.
Supports case-sensitive and case-insensitive validation based on the ignoreCase flag.
Supports both Enum constants and manually provided allowed values.

The validator is implemented with the following:

OneOfValidator class implementing ConstraintValidator<OneOf, CharSequence>.
Adds values from allowedValues() and enumClass() in the OneOf annotation for validation.
Provides methods to handle case-sensitive and case-insensitive validation.

Tests have been added, and all tests pass.

[Please describe here what your change is about]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on licensing, please check here.

Description: Contributed a new OneOfValidator for the Hibernate Validator project. This validator checks if a given CharSequence matches one of the allowed values specified in the OneOf annotation. Features: - Validates if a CharSequence is one of the allowed values. - Supports case-sensitive and case-insensitive validation based on the ignoreCase flag. - Supports both Enum constants and manually provided allowed values. The validator is implemented with the following: - OneOfValidator class implementing ConstraintValidator<OneOf, CharSequence>. - Adds values from allowedValues() and enumClass() in the OneOf annotation for validation. - Provides methods to handle case-sensitive and case-insensitive validation. Tests have been added, and all tests pass.

marko-bekhta · 2025-01-07T14:53:06Z

Hey @aalamu 👋🏻
Thanks for starting a pull request! I'll try to take a closer look and think more about the suggested constraint this week, but here are a few things:

From what I've seen, you have an enum and a string array as the source of "possible" values. Have you considered extending this to other types? The first thing that comes to mind here is JUnit's "argument sources" for parameterised tests: https://junit.org/junit5/docs/current/user-guide/#writing-tests-parameterized-tests-sources.
We have this post on adding new constraints: https://in.relation.to/2018/01/04/adding-new-constraint-to-engine/. It describes all the steps so that we don't miss anything. You can take a look to see what's needed in general, but I suggest we figure out the constraint itself and how it should/could behave first, then go back to these instructions to add all we need.