Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes around dialects #9638

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

gavinking
Copy link
Member

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Jan 18, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [d79f1fd, ab08353, 325810f, bb104e3, adf607a, 688c8b7]

› This message was automatically generated.

@gavinking
Copy link
Member Author

@loiclefevre Please review commit a4ee850 and let me know if there's anything you disagree with or if I broke something. Thanks!

to make the flow here a bit clearer
even if this is maybe not *precisely* the intent of DialectSpecificSettings
make things explicit that were implicit
note: system properties are already included in Environment properties
Looks like this has not worked since probably H 6.0

The issue here is that the test for this feature was one of these tests
written to look at the Hibernate metamodel and not at the actual DDL that
was ultimately generated. This is why I despise "unit" testing instead of
testing actual user-visible functionality.

Anyway this was an undocumented feature so it can just be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant