Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanups #9634

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Code cleanups #9634

merged 5 commits into from
Jan 17, 2025

Conversation

gavinking
Copy link
Member

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Jan 17, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [15842dc, 9677aba, a9ea918, d2c78f3, ca53d8a]

› This message was automatically generated.

final PluralAttributeMapping fetchable = (PluralAttributeMapping) fetchBuilder.getFetchable();
resultBuilder.addProperty(
fetchable.getIndexDescriptor(),
collectionPersister.getIndexColumnAliases( collectionSuffix )

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
CollectionPersister.getIndexColumnAliases
should be avoided because it has been deprecated.
collectionPersister.getIndexColumnAliases( collectionSuffix )
);
}
return asList( collectionPersister.getKeyColumnAliases( collectionSuffix ) );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
CollectionPersister.getKeyColumnAliases
should be avoided because it has been deprecated.
propertyType
loadable instanceof SingleTableEntityPersister singleTableEntityPersister
? singleTableEntityPersister.getSubclassPropertyType( index )
: loadable.getPropertyType( fetchable.getFetchableName() )

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EntityPersister.getPropertyType
should be avoided because it has been deprecated.
collectionReturn.getPluralAttribute(),
collectionPersister.getKeyColumnAliases( suffix ),
collectionPersister.hasIndex()
? collectionPersister.getIndexColumnAliases( suffix )

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
CollectionPersister.getIndexColumnAliases
should be avoided because it has been deprecated.
}
else {
elementColumnAliases = collectionPersister.getElementColumnAliases( suffix );
return collectionPersister.getElementColumnAliases( suffix );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
CollectionPersister.getElementColumnAliases
should be avoided because it has been deprecated.
Map<String, String[]> propertyResultsMap = Collections.emptyMap();//fetchReturn.getPropertyResultsMap()
addPersister( alias, propertyResultsMap, persister );
final EntityPersister ownerPersister = alias2Persister.get( ownerAlias );
final Type returnType = ownerPersister.getPropertyType( fetchReturn.getFetchable().getFetchableName() );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EntityPersister.getPropertyType
should be avoided because it has been deprecated.
@gavinking gavinking merged commit 88d689e into hibernate:main Jan 17, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant