-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test rolldown-vite #154
Draft
hi-ogawa
wants to merge
12
commits into
main
Choose a base branch
from
test-rolldown-vite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
test rolldown-vite #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
This reverts commit f52fc38.
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Feb 6, 2025
<!-- Thank you for contributing! --> ### Description Follow up to #3488. I forgot to test `emitFile({ type: "chunk" })` case and I just realized it's not working on hi-ogawa/vite-environment-examples#154. Currently, `FileEmitter::emitted_chunks` is not defined during scope hoisting finalizer, but it looks possible to define it earlier right after `generate_chunk_name_and_preliminary_filenames` instead of waiting until `instantiate_chunks`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo
examples/react-server
https://github.com/vitejs/vite-ecosystem-ci/blob/rolldown-vite/README-temp.md#vite-environment-examples
parseAstAsync
rollup/parseAst
virtual:copy-server-css.js
the issue is that 2nd rsc build's manifest includes css output which is only available in 1st rsc build.not only css, but also__client-CCH4vHkY.js
chunk is included in manifest.it looks like only manifest issue and two builds are mostly working fine.but the difference is that rolldown now generates_client.js
(and thus_client.css
) in 1st rsc build, which wasn't the case. Maybe I was relying on no side effect elision, which is not working on rolldown?but the difference is that previously there are less chunks in rollup and thus manifest entry is overwritten without stale content showing up after 2nd rsc build
though we might need to revisit double environment build to avoid this type of issue
examples/web-worker
import.meta.ROLLUP_FILE_URL_xxx
import.meta.ROLLUP_FILE_URL_(referenceId)
rolldown/rolldown#3488emitFile({ type: "chunk" }