Explicitly declare units field in PintType
#214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve mypy compatibility by declaring `units` to be a field of PintType. Signed-off-by: Michael Tiemann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve mypy compatibility by declaring
unitsto be a field of PintType.pre-commit run --all-fileswith no errorsI don't believe this change is docs-worthy, as it doesn't change any user-visible functionality (other than to make mypy more accepting of accessing the
unitsfield ofPintType). It is implicitly covered by automated unit tests because it changes no functionality the unit tests were written to test.