Skip to content

Commit

Permalink
sodadata#208: fix soda analyze error on mysql
Browse files Browse the repository at this point in the history
  • Loading branch information
chao.bi committed Sep 22, 2022
1 parent d19e86e commit b61e677
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/mysql/sodasql/dialects/mysql_dialect.py
Original file line number Diff line number Diff line change
Expand Up @@ -861,12 +861,12 @@ def is_time(self, column_type: str):
]

def qualify_table_name(self, table_name: str) -> str:
if table_name in self.reserved_keywords:
if table_name.upper() in self.reserved_keywords:
return f'`{table_name}`'
return table_name

def qualify_column_name(self, column_name: str, source_type: str = None):
if column_name in self.reserved_keywords:
if column_name.upper() in self.reserved_keywords:
return f'`{column_name}`'
return column_name

Expand All @@ -877,6 +877,8 @@ def qualify_regex(self, regex) -> str:
return self.escape_metacharacters(regex)

def sql_expr_regexp_like(self, expr: str, pattern: str):
if expr.upper() in self.reserved_keywords:
expr = f"`{expr}`"
return f"{expr} regexp '{self.qualify_regex(pattern)}'"

def sql_expr_cast_text_to_number(self, quoted_column_name, validity_format):
Expand Down

0 comments on commit b61e677

Please sign in to comment.