Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify the code to serve Hey API requirements #1

Merged
merged 3 commits into from
Dec 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
github: philsturgeon
github:
- mrlubos
- hey-api
63 changes: 34 additions & 29 deletions .github/workflows/CI-CD.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,16 @@ jobs:
- name: Run linter
run: yarn lint

- name: Run Node tests
run: yarn test:node
# disabled after refactoring
# - name: Run Node tests
# run: yarn test:node

- name: Send code coverage results to Coveralls
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
parallel: true
# disabled after refactoring
# - name: Send code coverage results to Coveralls
# uses: coverallsapp/github-action@v2
# with:
# github-token: ${{ secrets.GITHUB_TOKEN }}
# parallel: true

browser_tests:
name: Browser Tests
Expand All @@ -76,28 +78,31 @@ jobs:
- name: Install dependencies
run: yarn install --frozen-lockfile

- name: Run tests
run: yarn test:browser

- name: Send code coverage results to Coveralls
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
parallel: true

coverage:
name: Code Coverage
runs-on: ubuntu-latest
timeout-minutes: 5
needs:
- node_tests
- browser_tests
steps:
- name: Let Coveralls know that all tests have finished
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
parallel-finished: true
# disabled after refactoring
# - name: Run tests
# run: yarn test:browser

# disabled after refactoring
# - name: Send code coverage results to Coveralls
# uses: coverallsapp/github-action@v2
# with:
# github-token: ${{ secrets.GITHUB_TOKEN }}
# parallel: true

# disabled after refactoring
# coverage:
# name: Code Coverage
# runs-on: ubuntu-latest
# timeout-minutes: 5
# needs:
# - node_tests
# - browser_tests
# steps:
# - name: Let Coveralls know that all tests have finished
# uses: coverallsapp/github-action@v2
# with:
# github-token: ${{ secrets.GITHUB_TOKEN }}
# parallel-finished: true

release:
name: Release
Expand Down
894 changes: 0 additions & 894 deletions .yarn/releases/yarn-4.2.2.cjs

This file was deleted.

934 changes: 934 additions & 0 deletions .yarn/releases/yarn-4.5.3.cjs

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
nodeLinker: node-modules

yarnPath: .yarn/releases/yarn-4.2.2.cjs
yarnPath: .yarn/releases/yarn-4.5.3.cjs
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
> This is a modified fork to serve Hey API needs

# JSON Schema $Ref Parser

#### Parse, Resolve, and Dereference JSON Schema $ref pointers
Expand Down
28 changes: 14 additions & 14 deletions lib/bundle.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import $Ref from "./ref.js";
import type { ParserOptions } from "./options.js";
import Pointer from "./pointer.js";
import * as url from "./util/url.js";
import type $Refs from "./refs.js";
import type $RefParser from "./index";
import type { ParserOptions } from "./index";
import type { JSONSchema } from "./index";
import type { $RefParser } from "./index";
import type { JSONSchema } from "./types/index.js";

export interface InventoryEntry {
$ref: any;
Expand All @@ -28,15 +28,15 @@ export interface InventoryEntry {
* @param parser
* @param options
*/
function bundle<S extends object = JSONSchema, O extends ParserOptions<S> = ParserOptions<S>>(
parser: $RefParser<S, O>,
options: O,
function bundle(
parser: $RefParser,
options: ParserOptions,
) {
// console.log('Bundling $ref pointers in %s', parser.$refs._root$Ref.path);

// Build an inventory of all $ref pointers in the JSON Schema
const inventory: InventoryEntry[] = [];
crawl<S, O>(parser, "schema", parser.$refs._root$Ref.path + "#", "#", 0, inventory, parser.$refs, options);
crawl<JSONSchema>(parser, "schema", parser.$refs._root$Ref.path + "#", "#", 0, inventory, parser.$refs, options);

// Remap all $ref pointers
remap(inventory);
Expand All @@ -54,15 +54,15 @@ function bundle<S extends object = JSONSchema, O extends ParserOptions<S> = Pars
* @param $refs
* @param options
*/
function crawl<S extends object = JSONSchema, O extends ParserOptions<S> = ParserOptions<S>>(
parent: object | $RefParser<S, O>,
function crawl<S extends object = JSONSchema>(
parent: object | $RefParser,
key: string | null,
path: string,
pathFromRoot: string,
indirections: number,
inventory: InventoryEntry[],
$refs: $Refs<S, O>,
options: O,
$refs: $Refs<S>,
options: ParserOptions,
) {
const obj = key === null ? parent : parent[key as keyof typeof parent];

Expand Down Expand Up @@ -115,15 +115,15 @@ function crawl<S extends object = JSONSchema, O extends ParserOptions<S> = Parse
* @param $refs
* @param options
*/
function inventory$Ref<S extends object = JSONSchema, O extends ParserOptions<S> = ParserOptions<S>>(
function inventory$Ref<S extends object = JSONSchema>(
$refParent: any,
$refKey: string | null,
path: string,
pathFromRoot: string,
indirections: number,
inventory: InventoryEntry[],
$refs: $Refs<S, O>,
options: O,
$refs: $Refs<S>,
options: ParserOptions,
) {
const $ref = $refKey === null ? $refParent : $refParent[$refKey];
const $refPath = url.resolve(path, $ref.$ref);
Expand Down
30 changes: 14 additions & 16 deletions lib/dereference.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import * as url from "./util/url.js";
import type $Refs from "./refs.js";
import type { DereferenceOptions, ParserOptions } from "./options.js";
import type { JSONSchema } from "./types";
import type $RefParser from "./index";
import type { $RefParser } from "./index";
import { TimeoutError } from "./util/errors";

export default dereference;
Expand All @@ -17,13 +17,13 @@ export default dereference;
* @param parser
* @param options
*/
function dereference<S extends object = JSONSchema, O extends ParserOptions<S> = ParserOptions<S>>(
parser: $RefParser<S, O>,
options: O,
function dereference(
parser: $RefParser,
options: ParserOptions,
) {
const start = Date.now();
// console.log('Dereferencing $ref pointers in %s', parser.$refs._root$Ref.path);
const dereferenced = crawl<S, O>(
const dereferenced = crawl<JSONSchema>(
parser.schema,
parser.$refs._root$Ref.path!,
"#",
Expand Down Expand Up @@ -52,15 +52,15 @@ function dereference<S extends object = JSONSchema, O extends ParserOptions<S> =
* @param startTime - The time when the dereferencing started
* @returns
*/
function crawl<S extends object = JSONSchema, O extends ParserOptions<S> = ParserOptions<S>>(
function crawl<S extends object = JSONSchema>(
obj: any,
path: string,
pathFromRoot: string,
parents: Set<any>,
processedObjects: Set<any>,
dereferencedCache: any,
$refs: $Refs<S, O>,
options: O,
$refs: $Refs<S>,
options: ParserOptions,
startTime: number,
) {
let dereferenced;
Expand All @@ -82,7 +82,7 @@ function crawl<S extends object = JSONSchema, O extends ParserOptions<S> = Parse
parents.add(obj);
processedObjects.add(obj);

if ($Ref.isAllowed$Ref(obj, options)) {
if ($Ref.isAllowed$Ref(obj)) {
dereferenced = dereference$Ref(
obj,
path,
Expand All @@ -108,7 +108,7 @@ function crawl<S extends object = JSONSchema, O extends ParserOptions<S> = Parse
const value = obj[key];
let circular = false;

if ($Ref.isAllowed$Ref(value, options)) {
if ($Ref.isAllowed$Ref(value)) {
dereferenced = dereference$Ref(
value,
keyPath,
Expand Down Expand Up @@ -174,20 +174,18 @@ function crawl<S extends object = JSONSchema, O extends ParserOptions<S> = Parse
* @param options
* @returns
*/
function dereference$Ref<S extends object = JSONSchema, O extends ParserOptions<S> = ParserOptions<S>>(
function dereference$Ref<S extends object = JSONSchema>(
$ref: any,
path: string,
pathFromRoot: string,
parents: Set<any>,
processedObjects: any,
dereferencedCache: any,
$refs: $Refs<S, O>,
options: O,
$refs: $Refs<S>,
options: ParserOptions,
startTime: number,
) {
const isExternalRef = $Ref.isExternal$Ref($ref);
const shouldResolveOnCwd = isExternalRef && options?.dereference?.externalReferenceResolution === "root";
const $refPath = url.resolve(shouldResolveOnCwd ? url.cwd() : path, $ref.$ref);
const $refPath = url.resolve(path, $ref.$ref);

const cache = dereferencedCache.get($refPath);
if (cache && !cache.circular) {
Expand Down
Loading
Loading