Treat undefined as false for boolean variants
#146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskelton
force-pushed
the
fix-boolean-undefined
branch
from
4655773 to
18a1a33
Compare
|
@jrgarciadev Curious to get your thoughts on this one. I think it's reasonable to default to |
mskelton
force-pushed
the
fix-boolean-undefined
branch
from
18a1a33 to
0091d92
Compare
mskelton
force-pushed
the
fix-boolean-undefined
branch
from
0091d92 to
d8f5aa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141
Fixes #150