Revert "fix(input): use onPress for wrapper click focus"

[jrgarciadev]

Reverts #4483

Summary by CodeRabbit

• Refactor

  • Simplified input component's focus handling by removing separate click event handler
  • Integrated click event logic directly into wrapper prop getter functions
  • Removed unnecessary complexity in input interaction management

• Tests

  • Deleted test case verifying input focus behavior on click

[changeset-bot]

⚠️ No Changeset found

Latest commit: 89205ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
heroui	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jan 17, 2025 0:38am
heroui-sb	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jan 17, 2025 0:38am

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request involves modifications to the input component's focus handling mechanism. The changes primarily affect the useInput hook in the use-input.ts file, where the click event handling for input wrappers has been refactored. The separate handleInputWrapperClick function has been removed, and the focus logic is now directly integrated into the getInputWrapperProps and getInnerWrapperProps functions. Correspondingly, a related test case in the input component's test suite has been deleted.

Changes

File	Change Summary
packages/components/input/__tests__/input.test.tsx	Removed test case "should focus input on click"
packages/components/input/src/use-input.ts	- Removed handleInputWrapperClick function - Integrated click handling directly into getInputWrapperProps - Updated getInnerWrapperProps with direct click handling - Removed inputWrapperPressProps from mergeProps

Sequence Diagram

sequenceDiagram
    participant User
    participant InputWrapper
    participant Input
    
    User->>InputWrapper: Click
    InputWrapper->>Input: Focus
    Note over InputWrapper,Input: Focus logic now directly embedded in wrapper props

Loading

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3979dde and 89205ba.

📒 Files selected for processing (2)

• packages/components/input/__tests__/input.test.tsx (0 hunks)
• packages/components/input/src/use-input.ts (2 hunks)

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.