Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): chip with dot variant is not properly padded when having … #2387

Merged
merged 1 commit into from
Mar 3, 2024
Merged

fix(theme): chip with dot variant is not properly padded when having … #2387

merged 1 commit into from
Mar 3, 2024

Conversation

kuri-sun
Copy link
Contributor

…a 1-char text

Closes #2383

📝 Description

Chip is not properly padded when using the "dot" variant and using a 1-char string as children.

⛳️ Current behavior (updates)

Here is the previous style for the Chip component.

prev

🚀 New behavior

Here is the updated style for the Chip component.

curr2

curr

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Copy link

changeset-bot bot commented Feb 20, 2024

🦋 Changeset detected

Latest commit: 436fa97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/theme Major
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 4:22am

Copy link

vercel bot commented Feb 20, 2024

@kuri-sun is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @kuri-sun

@jrgarciadev jrgarciadev merged commit 141887d into heroui-inc:main Mar 3, 2024
7 of 8 checks passed
@kuri-sun kuri-sun deleted the fix/theme/chip-with-dot-variant-is-not-properly-padded-when-having branch March 3, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Chip] - Chip with dot variant is not properly padded when having a 1-char text
2 participants