Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output heading for package removal workflow when using dry-run mode #667

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

dzuelke
Copy link
Contributor

@dzuelke dzuelke commented Nov 29, 2023

The conditional has no else block, so GitHub will print 'false' instead of nothing, and as a result, the heading would read:

Packagesfalse removed from production bucket

@dzuelke dzuelke requested a review from a team as a code owner November 29, 2023 14:32
The conditional has no else block, so GitHub will print 'false' instead of nothing, and as a result, the heading would read:

> Packagesfalse removed from production bucket
@dzuelke dzuelke force-pushed the fix-removal-workflow-dry-run-output branch from 79f7b3f to 50ea36d Compare December 7, 2023 16:01
@dzuelke dzuelke merged commit 2ab4fca into main Dec 7, 2023
3 checks passed
@dzuelke dzuelke deleted the fix-removal-workflow-dry-run-output branch December 7, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants