Slight optimization

rhinventory/models/asset.py

@@ -215,11 +215,8 @@ def privacy(self, value: Privacy) -> None:
 
 
     def get_primary_image(self):
-        sorted_images = self.get_sorted_images()
-        if sorted_images:
-            return sorted_images[0]
-        return None
-
+        return self.get_sorted_images().first()
+
     @property
     def _query_files(self):
         return db.session.query(File) \
@@ -232,25 +229,19 @@ def get_files_in_categories(self, categories: list[FileCategory]):
         return self._query_files \
             .filter(
                 File.category.in_(categories)
-            ).all()
+            )
 
     def get_sorted_images(self):
         return self.get_files_in_categories(IMAGE_CATEGORIES)
 
     def get_primary_dump(self):
-        sorted_dumps = self.get_dumps()
-        if sorted_dumps:
-            return sorted_dumps[0]
-        return None
+        return self.get_dumps().first()
 
     def get_dumps(self):
         return self.get_files_in_categories([FileCategory.dump])
 
     def get_primary_document(self):
-        sorted_documents = self.get_files_in_categories([FileCategory.document])
-        if sorted_documents:
-            return sorted_documents[0]
-        return None
+        return self.get_files_in_categories([FileCategory.document]).first()
 
     @property
     def parents(self):

rhinventory/templates/admin/asset/_macros.html

@@ -34,7 +34,7 @@
     {% endif %}
     </span>
     <span>
-    {% if asset.get_dumps() %}
+    {% if asset.get_primary_dump() %}
         <a href="{{ asset.url }}">
             {{- icon("save") -}}
         </a>

rhinventory/templates/admin/asset/details.html

@@ -300,7 +300,7 @@ <h2><small>{{ render_asset_code(model) }}</small> {{ model.name }}</h2>
                     </div>
                 {% endif %}
             {% endmacro %}
-            {% set images = model.get_sorted_images() %}
+            {% set images = list(model.get_sorted_images()) %}
             {% if images %}
                 {{ render_asset_image(images[0], primary=True) }}
                 {% set secondary_images = images[1:] %}