Fix/Change llvm parsing order to support metadata referencing globals #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I still have my test code in here... gonna fix this |
|
Btw. the issue is related to the fact that LLVM Metadata can reference program constants but we parsed the metadata before we parsed the declarations. I just reordered the code, but I cannot tell if this is a general fix or if metadata parsing needs to be done differently altogether. |
|
@hernanponcedeleon I guess you do not care about this change anymore, right? IIRC, it was necessary to parse some UBSAN instrumentation. |
|
I think for now we can close for now (if we eventually need the code, we will have this PR to take a look to). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.