Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PPC grammar and visitor #762

Merged
merged 8 commits into from
Oct 28, 2024
Merged

Improve PPC grammar and visitor #762

merged 8 commits into from
Oct 28, 2024

Conversation

hernanponcedeleon
Copy link
Owner

The added litmus tests (automatically generated by diy7) shows several limitations of our PPC parser

  • missing support for exclusive instructions
  • not allowing locations to be referred as [x]
  • enforcing very specific format for labels
  • requiring branch instructions to be preceded by a cmp
  • throwing an exception if a register is read before being initialized instead of giving it a non-det value.

This PR fixes all these problems.

@hernanponcedeleon
Add exclusive load/store pairs to PPC litmus grammar and visitor
0482274 
Signed-off-by: Hernan Ponce de Leon <[email protected]>
@hernanponcedeleon
Fix PPC instruction name
7c787bc 
Signed-off-by: Hernan Ponce de Leon <[email protected]>
@hernanponcedeleon
More improvemes to PPC grammar
cc8f2c5 
Signed-off-by: Hernan Ponce de Leon <[email protected]>
@hernanponcedeleon
Add litmus test
95effa3 
Signed-off-by: Hernan Ponce de Leon <[email protected]>
@hernanponcedeleon
Support uninitilized registers
3a8fa99 
Signed-off-by: Hernan Ponce de Leon <[email protected]>
@hernanponcedeleon
Format
2525f05 
Signed-off-by: Hernan Ponce de Leon <[email protected]>
@hernanponcedeleon hernanponcedeleon changed the title Improve PPC grammar and visitor [DRAFT] Improve PPC grammar and visitor Oct 26, 2024
@hernanponcedeleon
Copy link
Owner Author

I just noticed I am using the wrong events for lwarx and stwcx., I should use ExecutionStatus.

@ThomasHaas
Copy link
Collaborator

You should use StoreExclusive in our events.arch package. That one compiles correctly.

@hernanponcedeleon hernanponcedeleon changed the title [DRAFT] Improve PPC grammar and visitor Improve PPC grammar and visitor Oct 26, 2024
ThomasHaas
ThomasHaas approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@ThomasHaas ThomasHaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hernanponcedeleon hernanponcedeleon merged commit 5478bfb into development Oct 28, 2024
1 check passed
@hernanponcedeleon hernanponcedeleon deleted the ppc branch October 28, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasHaas ThomasHaas ThomasHaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hernanponcedeleon @ThomasHaas