-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce stdlib.cat #751
Introduce stdlib.cat #751
Conversation
We did not always place the stdlib include at the beginning, for example in |
I thought about that, and I still decided to remove it to see if this already causes problems. I assume the |
The failed checks even include the |
Signed-off-by: Hernan Ponce de Leon <[email protected]>
65e7673
to
a4d1226
Compare
Maybe it is the non-det from #746 and this was just an unlucky run. |
But the non-det was supposed to only affect the new alias analysis which is disabled in |
Signed-off-by: Hernan Ponce de Leon <[email protected]>
The latest version of vmm already solves most of the issues, it only need to properly define EDIT: we don't need to redefine |
Signed-off-by: Hernan Ponce de Leon <[email protected]>
… to redefine) Signed-off-by: Hernan Ponce de Leon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In herd, most of what we defined in
basic.cat
is defined instdlib.cat
which is included by default in all models (see section 16.7 in https://diy.inria.fr/doc/herd.html).This PR mimics this behavior.