Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to CAAT for SyncBar and SyncFence relations #724

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

ThomasHaas
Copy link
Collaborator

CAAT still does not work with virtual memory objects, so it will produce wrong results on the PTX7.5 litmus tests.

@hernanponcedeleon
Copy link
Owner

You should at least enable caat in the spirv tests, e.g.

assertEquals(expected, RefinementSolver.run(ctx, prover, mkTask()).getResult());

@ThomasHaas
Copy link
Collaborator Author

ThomasHaas commented Sep 2, 2024

Some of those tests also use virtual memory objects, so I cannot enable all of them.

EDIT: Ok, I'm not sure if the tests actually contain virtual memory. I just saw errors related to vloc but vloc also relates accesses to physical memory.

@hernanponcedeleon
Copy link
Owner

Is the comment "refinement still fails to understand virtual memory" outdated? If not, in which benchmarks is this causing problems?

@ThomasHaas
Copy link
Collaborator Author

The comment is still valid and it will produce wrong results on PTX7.5 litmus tests. I haven't checked the details, but I believe the ExecutionModel just does not capture virtual accesses correctly and this causes Refinement to produce wrong results.

@ThomasHaas
Copy link
Collaborator Author

I should add: I think virtual addressing was added in a very ad hoc manner and has many flaws. If we really want to support it in the long run, we should properly think it through before trying to fit in the ad hoc solution into all the solver backends.

@hernanponcedeleon hernanponcedeleon merged commit 7887589 into development Sep 5, 2024
1 check passed
@hernanponcedeleon hernanponcedeleon deleted the gpu_models_caat_support branch September 5, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants