Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid exception in SyntacticContextAnalysis #699

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

hernanponcedeleon
Copy link
Owner

The current analysis throws an exception if function calls or loops do not satisfy certain well-formedness properties.

Since the analysis is not used for verification, but rather to give useful feedback to the user, whenever those conditions are not satisfied, we should give up the analysis instead of not giving the verification answer.

Copy link
Collaborator

@ThomasHaas ThomasHaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hernanponcedeleon hernanponcedeleon merged commit fa5a226 into development Jul 1, 2024
1 check passed
@hernanponcedeleon hernanponcedeleon deleted the metadata branch July 1, 2024 12:26
hernanponcedeleon added a commit that referenced this pull request Aug 28, 2024
Signed-off-by: Hernan Ponce de Leon <[email protected]>
Co-authored-by: Hernan Ponce de Leon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants