Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup VisitorXML #598

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Cleanup VisitorXML #598

merged 2 commits into from
Jan 3, 2024

Conversation

hernanponcedeleon
Copy link
Owner

The current witness visitor skips edges not having any metadata (e.g. C line) which causes problems (e.g., failing to find the violation node) for witnesses like this.

This PR cleans up the XML visitor used for parsing the witness.

Signed-off-by: Hernan Ponce de Leon <[email protected]>
@hernanponcedeleon hernanponcedeleon changed the base branch from master to development January 2, 2024 21:18
Copy link
Collaborator

@ThomasHaas ThomasHaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hernanponcedeleon hernanponcedeleon merged commit c1371f9 into development Jan 3, 2024
@hernanponcedeleon hernanponcedeleon deleted the witness-parser branch January 3, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants