Non-recursive implementation of DependencyGraph to avoid stack overflow #590
Conversation
…d stack overflows.
|
@ThomasHaas do you remember any benchmark having this problem? I thought we had some in svcomp, but I cannot find any. |
| // Recursion in progress (we returned from a deeper recursion level) | ||
| v.lowlink = Math.min(v.lowlink, lastVisited.lowlink); | ||
| } else { | ||
| assert false; |
There was a problem hiding this comment.
I guess this point should never be reached. Maybe we should add an error msg to this sanity check.
There was a problem hiding this comment.
I don't think an error message is reasonable for these kinds of invariants. But I will change the code to just have a else { assert (cond); ...} rather than else if (cond) { ...} else { assert false; }
There was a problem hiding this comment.
Once you do this change, I can merge
dartagnan/src/main/java/com/dat3m/dartagnan/utils/dependable/DependencyGraph.java
Show resolved
Hide resolved
No, there are probably some examples in the Slack channel. Anyway, the problem must be gone because the recursion is definitely gone and I don't need a unit test to tell you that :P. Of course, it might be interesting to check if the programs now show other issues. |
No description provided.