-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More control barrier tests #579
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f4de543
Add arrive control barrier to PTX
hernan-poncedeleon e722344
Add new barrier tests for vulkan
hernan-poncedeleon 34e144a
Add new barrier tests for ptx
hernan-poncedeleon 8be3663
Fix ACQ+REL = SEMSC0 + SEMC1 check
hernan-poncedeleon dcd0c4d
Fix benchmarks with ACQ+REL = SEMSC0 + SEMC1 problem
hernan-poncedeleon 948f7a3
Regenerate CADP tests guaranteeing ACQ+REL = SEMSC0 + SEMC1
hernan-poncedeleon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 1 addition & 5 deletions
6
dartagnan/src/main/java/com/dat3m/dartagnan/program/processing/compilation/VisitorPTX.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
PTX PC-bar-sync-arrive | ||
"Producer-Consumer pattern using named barriers. | ||
Arrive does not block P1. | ||
Load and store are not ordered." | ||
{ | ||
x=0; | ||
P0:r0=0 | ||
} | ||
P0@cta 0,gpu 0 | P1@cta 0,gpu 0 ; | ||
ld.weak r0, x | bar.cta.arrive 1 ; | ||
bar.cta.sync 0 | st.weak x, 1 ; | ||
bar.cta.arrive 1 | bar.cta.sync 0 ; | ||
exists | ||
(P0:r0 == 1) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
PTX PC-bar-sync-sync-1 | ||
"Producer-Consumer pattern using named barriers. | ||
Load is ordered before store due to sync over 0." | ||
{ | ||
x=0; | ||
P0:r0=0 | ||
} | ||
P0@cta 0,gpu 0 | P1@cta 0,gpu 0 ; | ||
ld.weak r0, x | bar.cta.sync 0 ; | ||
bar.cta.sync 0 | st.weak x, 1 ; | ||
bar.cta.sync 1 | bar.cta.sync 1 ; | ||
~exists | ||
(P0:r0 == 1) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
PTX PC-bar-sync-sync-2 | ||
"Producer-Consumer pattern using named barriers. | ||
Load is ordered before store due to sync over 0." | ||
{ | ||
x=0; | ||
P0:r0=0 | ||
} | ||
P0@cta 0,gpu 0 | P1@cta 0,gpu 0 ; | ||
ld.weak r0, x | bar.cta.sync 0 ; | ||
bar.cta.sync 0 | st.weak x, 1 ; | ||
bar.cta.sync 1 | bar.cta.sync 1 ; | ||
exists | ||
(P0:r0 == 0) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
PTX PC-bar-sync-sync-3 | ||
"Producer-Consumer pattern using named barriers. | ||
Deadlock." | ||
{ | ||
x=0; | ||
P0:r0=0 | ||
} | ||
P0@cta 0,gpu 0 | P1@cta 0,gpu 0 ; | ||
ld.weak r0, x | bar.cta.sync 1 ; | ||
bar.cta.sync 0 | st.weak x, 1 ; | ||
bar.cta.sync 1 | bar.cta.sync 0 ; | ||
~exists | ||
(P0:r0 == 1) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
PTX PC-bar-sync-sync-4 | ||
"Producer-Consumer pattern using named barriers. | ||
Deadlock." | ||
{ | ||
x=0; | ||
P0:r0=0 | ||
} | ||
P0@cta 0,gpu 0 | P1@cta 0,gpu 0 ; | ||
ld.weak r0, x | bar.cta.sync 1 ; | ||
bar.cta.sync 0 | st.weak x, 1 ; | ||
bar.cta.sync 1 | bar.cta.sync 0 ; | ||
~exists | ||
(P0:r0 == 0) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is
bar.red
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't currently support those instructions, but I just copied the comment above from the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I think the current implementation support (
bar.sync
,bar.sync
) and (bar.arrive
,bar.sync
).Shall we also update the comments on two ptx cat files about the
sync_barrier
relation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need that level of detail in the cat file. E.g. we do not specify either all the cases covered by
sr
.