add privIsScoped check and update tests #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cat/spirv-check.cat
Outdated
| @@ -172,6 +172,10 @@ flag ~empty nonprivIsRW as checkNonprivIsRW | |||
| let atomicIsNonpriv = ([ATOM] \ [NONPRIV]) | |||
| flag ~empty atomicIsNonpriv as checkAtomicIsNonpriv | |||
|
|
|||
| // Private operations are not scoped | |||
| let privIsScoped = (([M \ NONPRIV]) & [DV | QF | WG | SG]) | |||
There was a problem hiding this comment.
You can use PRIV instead
There was a problem hiding this comment.
Right I forgot, updated.
hernanponcedeleon
merged commit 27f88cd
into
hernanponcedeleon:development
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes adding
NON_PRIVATEtag to scoped operations in the Vulkan model.Instead, it makes it a sanitor check that all private operations should not be scoped.