Benchmarks coming from GPU concurrency: Weak behaviours and programming assumptions #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urs and programming assumptions Signed-off-by: Hernan Ponce de Leon <[email protected]>
tonghaining
reviewed
Nov 6, 2023
tonghaining
reviewed
Nov 6, 2023
tonghaining
reviewed
Nov 6, 2023
Signed-off-by: Hernan Ponce de Leon <[email protected]>
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found two issues in the litmus tests coming from the "GPU concurrency: Weak behaviours and programming assumptions" paper.
.cgwhich is supposed to invalidate the L2 cache. Since the L2 is shared between all threads in the GPU, it makes sense to me that this is actually related to the.gpuscopest.cgandld.cgare relaxed stores and loads (volatile are the weak ones)@tonghaining can you please check this makes sense?