Add comment

Updated verdict of VMMLocksTest
hernanponcedeleon · Nov 25, 2024 · a8805c7 · a8805c7
1 parent 0d32a25
commit a8805c7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/dartagnan/src/main/java/com/dat3m/dartagnan/program/processing/DynamicSpinLoopDetection.java b/dartagnan/src/main/java/com/dat3m/dartagnan/program/processing/DynamicSpinLoopDetection.java
@@ -86,6 +86,7 @@ private void collectSideEffects(LoopData loop, LiveRegistersAnalysis liveRegsAna
             }
         } while ((cur = cur.getSuccessor()) != loop.getEnd().getSuccessor());
 
+        // Every live register that is written to is a potential local side effect.
         loop.writtenLiveRegisters.addAll(Sets.intersection(
                 writtenRegisters,
                 liveRegsAna.getLiveRegistersAt(loop.getStart())

diff --git a/dartagnan/src/test/java/com/dat3m/dartagnan/c/VMMLocksTest.java b/dartagnan/src/test/java/com/dat3m/dartagnan/c/VMMLocksTest.java
@@ -16,10 +16,10 @@
 import java.util.EnumSet;
 
 import static com.dat3m.dartagnan.configuration.Arch.C11;
+import static com.dat3m.dartagnan.configuration.Property.*;
 import static com.dat3m.dartagnan.utils.ResourceHelper.getTestResourcePath;
 import static com.dat3m.dartagnan.utils.Result.*;
 import static org.junit.Assert.assertEquals;
-import static com.dat3m.dartagnan.configuration.Property.*;
 
 @RunWith(Parameterized.class)
 public class VMMLocksTest extends AbstractCTest {
@@ -82,7 +82,7 @@ public static Iterable<Object[]> data() throws IOException {
                 {"mutex_musl-rel2rx_futex", C11, FAIL},
                 {"mutex_musl-rel2rx_unlock", C11, FAIL},
                 {"seqlock", C11, PASS},
-                {"clh_mutex", C11, UNKNOWN},
+                {"clh_mutex", C11, PASS},
                 {"clh_mutex-acq2rx", C11, FAIL},
                 {"ticket_awnsb_mutex", C11, PASS},
                 {"ticket_awnsb_mutex-acq2rx", C11, FAIL},