Skip to content

Commit

Permalink
Removed outdated comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ThomasHaas committed Jan 22, 2024
1 parent 2584b6c commit 2a27885
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ public boolean combine(BigInteger a, BigInteger b){
};
}

// Due to constant propagation, and the lack of a proper type system
// we can end up with comparisons like "False == 1", thus the following two methods
public boolean combine(boolean a, BigInteger b){
return switch (this) {
case EQ -> ((b.compareTo(BigInteger.ONE) == 0) == a);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ private void processResults(Local e) {
Expression base = iBin.getLHS();
if (base instanceof MemoryObject mem) {
Expression rhs = iBin.getRHS();
//FIXME Address extends IntLiteral
if (rhs instanceof IntLiteral ic) {
addTarget(reg, new Location(mem, ic.getValueAsInt()));
} else {
Expand All @@ -226,7 +225,6 @@ private void processResults(Local e) {
//accept register2 = register1 + constant
for (Location target : targets.getOrDefault(base, Set.of())) {
Expression rhs = ((IntBinaryExpr) exp).getRHS();
//FIXME Address extends IntLiteral
if (rhs instanceof IntLiteral ic) {
int o = target.offset + ic.getValueAsInt();
if (o < target.base.size()) {
Expand All @@ -253,7 +251,7 @@ private void processResults(MemoryCoreEvent e) {
addresses = ImmutableSet.of(addressConstant.location);
}
}
if (addresses.size() == 0) {
if (addresses.isEmpty()) {
addresses = maxAddressSet;
}
eventAddressSpaceMap.put(e, ImmutableSet.copyOf(addresses));
Expand Down

0 comments on commit 2a27885

Please sign in to comment.