fix parser

This reverts commit c4e901f07fbf8151cc5213f7532e59a3083f7ea4.

XYZHubConnector/xyz_qgis/layer/parser.py

@@ -523,31 +523,32 @@ def xyz_json_to_feature_map(
             100: map_fields should have as many as possible fields/geom
     """
 
-    def _single_feature_map(feat_json, map_feat, map_fields):
+    def _single_feature_map(feat_json, map_feat_, map_fields_):
         geom = feat_json.get("geometry")
         g = geom["type"] if geom is not None else None
 
         # # promote to multi geom
         # if g is not None and not g.startswith("Multi"): g = "Multi" + g
 
-        lst_fields = map_fields.setdefault(g, list())
+        lst_fields = map_fields_.setdefault(g, list())
         fields, idx = prepare_fields(feat_json, lst_fields, similarity_threshold)
 
-        ft = xyz_json_to_feature(feat_json, fields)
+        feat = xyz_json_to_feature(feat_json, fields)
+        lst_fields[idx] = feat.fields()
+        # FIX: as fields is modified during processing, reassign it to lst_fields
 
-        lst = map_feat.setdefault(g, list())
+        lst_feat = map_feat_.setdefault(g, list())
+        while len(lst_feat) < len(lst_fields):
+            lst_feat.append(list())
+        lst_feat[idx].append(feat)
 
-        while len(lst) < len(lst_fields):
-            lst.append(list())
-        lst[idx].append(ft)
-
-    lst_feat = obj["features"]
+    lst_all_feat = obj["features"]
     if map_fields is None:
         map_fields = dict()
     # map_feat = dict()
     map_feat = dict((k, [list() for _ in enumerate(v)]) for k, v in map_fields.items())
 
-    for ft in lst_feat:
+    for ft in lst_all_feat:
         _single_feature_map(ft, map_feat, map_fields)
 
     return map_feat, map_fields