Error message for MacOS mixed Racket and Rust install #570
Conversation
conflict between racket and rust on MacOS
egg-herbie/main.rkt
Outdated
| (define (check-for-rosetta) | ||
| (equal? (with-output-to-string (lambda () (system "sysctl -n sysctl.proc_translated"))) "1\n")) |
There was a problem hiding this comment.
I would move the tests for architecture and OS into here. For two reasons:
- Make this function safer—that is, it won't execute an unknown command if it is called on Linux or Windows.
- Logically, if you're not on macOS or you are running in ARM, you're definitely not in Rosetta
There was a problem hiding this comment.
Also, instead of calling it check-for-rosetta, let's call it running-on-rosetta?. This is a function that returns a boolean.
egg-herbie/main.rkt
Outdated
| (equal? (with-output-to-string (lambda () (system "sysctl -n sysctl.proc_translated"))) "1\n")) | ||
|
|
||
| (define fallback-message | ||
| "Error: unable to load the 'egg-math' library.") |
There was a problem hiding this comment.
This one starts with Error: but the one below doesn't. You should make them match up. Also, why not add a link to the bug tracker and say "Please file a bug here: "?
reorder conditional logic
Co-authored-by: Pavel Panchekha <[email protected]>
|
@pavpanchekha ok should be good. Let me know if that's not the logical ordering you were looking for. |
egg-herbie/main.rkt
Outdated
| (define-ffi-definer define-eggmath (ffi-lib libeggmath-path)) | ||
| ; Checks if Racket is being run in emulation via rosetta | ||
| (define (running-on-rosetta?) | ||
| (if (and (equal? (system-type 'os) 'macosx) |
There was a problem hiding this comment.
Why do an if where the else branch is false? It should just be part of the and
egg-herbie/main.rkt
Outdated
| (define fallback-message | ||
| (string-join | ||
| `("Error: unable to load the 'egg-math' library" | ||
| "Please file a bug at \"https://github.com/herbie-fp/herbie/issues\"") |
There was a problem hiding this comment.
Also, I would drop the quotes around the URL; you don't have them in the other message.
consistent link messages
On MacOS, detects if an x86 version of Racket is installed on an ARM Mac computers. Then prompts the user to install the Apple Silicon version of Racket.