Bug/992 precision loss #993
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
==========================================
- Coverage 92.26% 92.24% -0.02%
==========================================
Files 84 84
Lines 12447 12454 +7
==========================================
+ Hits 11484 11488 +4
- Misses 963 966 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This pull request is stale because it has been open for 60 days with no activity. |
|
This pull request is stale because it has been open for 60 days with no activity. |
|
This pull request is stale because it has been open for 60 days with no activity. |
github-actions
bot
added
backport stable
core
linalg
testing
|
Thank you for the PR! |
|
Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed precision loss in several functions when using
float64data type.Issue/s resolved: #992
Changes proposed:
dtypeargument to backend torch functions instead of converting to desired data type after using default torch data type.Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no
skip ci