Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror repository on gitlab + ci #1025

Merged
merged 63 commits into from
Sep 13, 2022
Merged

mirror repository on gitlab + ci #1025

merged 63 commits into from
Sep 13, 2022

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Sep 6, 2022

Description

This PR uses a GitHub action to mirror the repository on self-hosted GitLab and run the CI there.

skip ci

ClaudiaComito and others added 30 commits April 27, 2022 14:53
* wip: Initial release draft and changelog updater actions configuration

* doc: pr title style guide in contibuting.md

* ci: improved release draft templates

* ci: extra release draft categories

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Claudia Comito <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* doc: parallel tutorial note metioning local and global printing

* doc: extenden local print note with ``ht.local_printing()``

* Fix typo

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Claudia Comito <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Updated the tutorial document.

1. Corrected the spelling mistake -> (sigular to single)
2. Corrected the statement -> the number of dimensions is the rank of the array.
3. Made 2 more small changes.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix typo

Co-authored-by: Claudia Comito <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates:
- [github.com/psf/black: 22.3.0 → 22.6.0](psf/black@22.3.0...22.6.0)
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1025 (e160224) into release/1.2.x (2e6c363) will decrease coverage by 4.41%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           release/1.2.x    #1025      +/-   ##
=================================================
- Coverage          95.51%   91.10%   -4.42%     
=================================================
  Files                 65       65              
  Lines               9976     9974       -2     
=================================================
- Hits                9529     9087     -442     
- Misses               447      887     +440     
Flag Coverage Δ
gpu ?
unit 91.10% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/factories.py 99.24% <100.00%> (-0.76%) ⬇️
heat/core/types.py 96.81% <100.00%> (-0.03%) ⬇️
heat/core/version.py 75.00% <100.00%> (-12.50%) ⬇️
heat/optim/dp_optimizer.py 24.19% <0.00%> (-71.89%) ⬇️
heat/core/stride_tricks.py 81.53% <0.00%> (-12.31%) ⬇️
heat/core/devices.py 86.66% <0.00%> (-11.12%) ⬇️
heat/nn/data_parallel.py 84.13% <0.00%> (-10.35%) ⬇️
heat/cluster/spectral.py 85.71% <0.00%> (-8.58%) ⬇️
heat/core/communication.py 89.94% <0.00%> (-6.84%) ⬇️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mtar mtar added testing Implementation of tests, or test-related issues High priority, urgent labels Sep 6, 2022
@mtar mtar marked this pull request as draft September 6, 2022 11:56
@ghost
Copy link

ghost commented Sep 6, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@mtar mtar marked this pull request as ready for review September 9, 2022 16:28
ClaudiaComito
ClaudiaComito previously approved these changes Sep 9, 2022
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mtar !!

Any idea why the code coverage has dropped so much? We were at 91% without the GPU tests.

Also, I wasn't able to view the actual line-by-line code coverage.

But I would say, let's merge this and have the CI running again on all the new PRs.

@mtar
Copy link
Collaborator Author

mtar commented Sep 13, 2022

@ClaudiaComito Is the coverage better now?

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant @mtar!

@ClaudiaComito ClaudiaComito changed the base branch from main to release/1.2.x September 13, 2022 08:50
@mtar mtar requested a review from ClaudiaComito September 13, 2022 09:03
@ClaudiaComito ClaudiaComito merged commit 23623e6 into release/1.2.x Sep 13, 2022
@ClaudiaComito ClaudiaComito deleted the mirror-ci branch September 13, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High priority, urgent testing Implementation of tests, or test-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants