fix: add child/parent support to import-values #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scodeman
force-pushed
the
bugfix/import-values
branch
2 times, most recently
from
95c4776 to
377490a
Compare
|
@scodeman please fix ci issue. |
scodeman
force-pushed
the
bugfix/import-values
branch
from
0298d9a to
441c9ba
Compare
Signed-off-by: GitHub <[email protected]>
scodeman
force-pushed
the
bugfix/import-values
branch
from
441c9ba to
1035d5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to helmfile/helmfile#1893
There is a difference in the way chartify and helm manages ImportValues inside Dependency type that seem to be the root of the issue
ImportValues []interface{}as seen in https://github.com/helm/helm/blob/v3.17.0/pkg/chart/dependency.goImportValues []stringas seen in https://github.com/helmfile/chartify/blob/v0.20.7/requirements.goThis leads to unmarshalling issues
cannot unmarshal !!map into stringwhen using the child/parent sublist items possibility for import-values