feat(feedback): submit browser

hello-nrfcloud · Sep 27, 2024 · d208466 · d208466
1 parent 5d3dac8
commit d208466
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/features/Feedback.feature.md b/features/Feedback.feature.md
@@ -26,7 +26,8 @@ When I `POST` to `${APIURL}/feedback` with
 {
   "email": "${email}",
   "stars": 4,
-  "suggestion": "None, everything worked well!"
+  "suggestion": "None, everything worked well!",
+  "browser": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36"
 }
 ```
 
@@ -48,12 +49,16 @@ content-type: application/json; charset=utf-8
     {
       "facts": [
         {
-          "name": "Rating:",
+          "name": "Rating",
           "value": "★★★★☆"
         },
         {
-          "name": "Email:",
+          "name": "Email",
           "value": "${email}"
+        },
+        {
+          "name": "Browser",
+          "value": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36"
         }
       ],
       "text": "None, everything worked well!"

diff --git a/lambda/feedback.ts b/lambda/feedback.ts
@@ -31,13 +31,14 @@ const InputSchema = Type.Object({
 	stars: Type.Integer({ minimum: 1, maximum: 5, title: 'Star rating' }),
 	suggestion: Type.String({ minLength: 1, title: 'Suggestion' }),
 	email: Type.RegExp(/.+@.+/, { title: 'Email' }),
+	browser: Type.String({ minLength: 1, title: 'Non-empty string' }),
 })
 
 const h = async (
 	event: APIGatewayProxyEventV2,
 	context: ValidInput<typeof InputSchema> & Context,
 ): Promise<APIGatewayProxyResultV2> => {
-	const { stars, email, suggestion } = context.validInput
+	const { stars, email, suggestion, browser } = context.validInput
 
 	const res = await fetch(settings.webhookURL, {
 		method: 'POST',
@@ -54,13 +55,17 @@ const h = async (
 				{
 					facts: [
 						{
-							name: 'Rating:',
+							name: 'Rating',
 							value: '★'.repeat(stars) + '☆'.repeat(5 - stars),
 						},
 						{
-							name: 'Email:',
+							name: 'Email',
 							value: email,
 						},
+						{
+							name: 'Browser',
+							value: browser,
+						},
 					],
 					text: suggestion,
 				},