feat: allow multiple language servers for a hover event #12686
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for previewing hover responses from multiple language server. For example, with two language servers (
taplo
andharper-ls
), this will be presented on hover:Instead of this (what is currently shown):
Currently, helix will choose the first language server that supports
hover
, and only work with it.I wanted this feature, as I was working with multiple language servers, that both provide hover. Also, I saw a TODO in the hover function that suggests that this is something we want:
helix/helix-term/src/commands/lsp.rs
Line 1014 in aac0ce5
This is my first PR, so please point my attention if I missed something.