Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow multiple language servers for a hover event #12686

Closed
wants to merge 2 commits into from

Conversation

rotmh
Copy link

@rotmh rotmh commented Jan 26, 2025

This is a draft for previewing hover responses from multiple language server. For example, with two language servers (taplo and harper-ls), this will be presented on hover:

taplo

This is the rust edition, valid options are...

---

harper-ls

Did you mean to spell `didnt` this way?

Instead of this (what is currently shown):

This is the rust edition, valid options are...

Currently, helix will choose the first language server that supports hover, and only work with it.

I wanted this feature, as I was working with multiple language servers, that both provide hover. Also, I saw a TODO in the hover function that suggests that this is something we want:

// TODO support multiple language servers (merge UI somehow)

This is my first PR, so please point my attention if I missed something.

@rotmh rotmh marked this pull request as draft January 26, 2025 15:46
@rotmh rotmh marked this pull request as ready for review January 26, 2025 16:02
@the-mikedavis
Copy link
Member

I've just merged #10122 which adds the UI for hover with multiple language servers so this can be closed out. Note that the UI is a bit different #9744 is similar to this change but in #10122 each hover response is cycled through with A-n/A-p

@rotmh
Copy link
Author

rotmh commented Jan 26, 2025

Oh, cool! Sorry for not noticing that PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants