fix(commands): fix an off-by-one in toggle_option
#12426
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the off-by-one, it would work only if the first option was not the same something as what the option was currently set. Now, it properly toggles.
There is still an existing issue that this way of toggling really only toggles for two options, but more are supposed to be accepted. I would argue though that is actually what "toggle" is supposed to be, not a "cycle".