Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update price env to svelte's env import #241

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

joeetwork
Copy link
Contributor

updated the price api key import to svelte's native import.

Copy link

vercel bot commented Dec 5, 2023

@joeetwork is attempting to deploy a commit to the helius Team on Vercel.

A member of the Team first needs to authorize it.

@joeetwork joeetwork marked this pull request as ready for review December 5, 2023 19:51
@0xIchigo 0xIchigo assigned 0xIchigo and unassigned 0xIchigo Dec 5, 2023
@0xIchigo 0xIchigo self-requested a review December 5, 2023 20:08
Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
xray-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 8:07pm

@qudo-code
Copy link
Contributor

@0xIchigo can you make a new environment variable on vercel called BIRDEYE_API_KEY that is the same value as VITE_BIRDEYE_API_KEY? Prefixing with VITE_ will expose the variable to the client.

@joeetwork if the above happens, you could update this PR to point to BIRDEYE_API_KEY else, its still a fix as is I guess and we can change later.

Copy link
Contributor

@0xIchigo 0xIchigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the PR! I've went ahead and added both BIRDEYE_API_KEY and VITE_BIRDEYE_API_KEY as environment variables on Vercel. Can you please refactor the PR to use Svelte's imports? I'll approve and merge the PR once that's completed

Copy link
Contributor

@0xIchigo 0xIchigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xIchigo 0xIchigo added this pull request to the merge queue Dec 8, 2023
Merged via the queue into helius-labs:dev with commit 3af45a2 Dec 8, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants