Fix Go names case #142
Merged
Fix Go names case #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpcosal
force-pushed
the
fix/go-names-case
branch
from
d0f46fc to
0b36567
Compare
adrianmester
approved these changes
Nov 29, 2024
jpcosal
reviewed
Nov 29, 2024
| @@ -0,0 +1,15 @@ | |||
| module dummy | |||
There was a problem hiding this comment.
go.mod is to prevent generated code from being scanned as part of avro code
jpcosal
force-pushed
the
fix/go-names-case
branch
from
0b36567 to
73f4520
Compare
skateinmars
approved these changes
Nov 29, 2024
clement-heetch
commented
Dec 1, 2024
| @@ -75,3 +78,17 @@ func TestShouldImportAvroTypeGen(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestGenerate(t *testing.T) { | |||
clement-heetch
commented
Dec 1, 2024
| @@ -0,0 +1,135 @@ | |||
|
|
|||
| // Code generated by avrogen. DO NOT EDIT. | |||
There was a problem hiding this comment.
indentation looks pretty weird :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.4.5 introduced a regression where the case for generated Go code changed.
This PR restores the original behavior.
Tests
Non regression unit tests have been introduced, using golden files.
Sample test schema is an actual file taken from contract repo (billing_and_charging/entities/attempt/v1/attempt.avsc)