Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for AVX on boot #917

Closed
wants to merge 1 commit into from
Closed

Added check for AVX on boot #917

wants to merge 1 commit into from

Conversation

hyperbx
Copy link
Member

@hyperbx hyperbx commented Mar 4, 2025

TODO:

  • Localise the error message in locale.cpp.
  • Test on unsupported hardware (if failing, compile main.cpp with no-avx flag).
  • Test on platforms other than Windows.

@hyperbx hyperbx marked this pull request as draft March 4, 2025 08:17
@grantmulholland
Copy link

Might not work out if hedge-dev/XenonRecomp#22 gets merged?

@DeaTh-G DeaTh-G added this to the v1.0.2 milestone Mar 4, 2025
@hyperbx
Copy link
Member Author

hyperbx commented Mar 4, 2025

Might not work out if hedge-dev/XenonRecomp#22 gets merged?

I've added compile-time checks for x86 now, os::host::IsCapableCPU() now returns true on other architectures. It'll be the responsibility of those implementing support for other architectures to determine which features are supported or not.

@hyperbx
Copy link
Member Author

hyperbx commented Mar 4, 2025

Tested on unsupported hardware, ran into an illegal instruction. The static initialisers are probably being emitted with AVX code, which would be a bit of a pain to maintain. Closing for now.

@hyperbx hyperbx closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants